Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sd-radio #68

Merged
merged 9 commits into from
Nov 5, 2024
Merged

feat: add sd-radio #68

merged 9 commits into from
Nov 5, 2024

Conversation

GeekyEggo
Copy link
Member

@GeekyEggo GeekyEggo commented Nov 1, 2024

This PR enables standalone radio buttons using a new <sd-radio /> component. In addition to this it also:

  • Updates <sd-radiogroup /> to dynamically update based on it's child options.
  • Updates <sd-option /> to prefer label attribute instead of innerText.
  • Updates <sd-radio /> to render the innerText if a label is not specified.
  • Replaces MutationController with a dedicated OptionController for better monitoring.

@GeekyEggo GeekyEggo marked this pull request as draft November 4, 2024 10:15
@GeekyEggo GeekyEggo marked this pull request as ready for review November 4, 2024 10:37
@GeekyEggo GeekyEggo marked this pull request as draft November 4, 2024 16:08
@GeekyEggo GeekyEggo marked this pull request as ready for review November 4, 2024 18:33
@GeekyEggo GeekyEggo merged commit 47a784a into features/ui Nov 5, 2024
2 checks passed
@GeekyEggo GeekyEggo deleted the radio-button branch November 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants