Remove redundant copying

elgopher · Jan 22, 2022 · bed9cc7 · bed9cc7
1 parent a629075
commit bed9cc7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/adapter/contextadapter/contextadapter.go b/adapter/contextadapter/contextadapter.go
@@ -24,8 +24,7 @@ func (p adapter) Log(ctx context.Context, entry logger.Entry) {
 	contextLogger := ctx.Value(p.contextKey)
 	loggerAdapter := p.adapterFromContextLogger(contextLogger)
 
-	newEntry := entry
-	newEntry.SkippedCallerFrames++
+	entry.SkippedCallerFrames++
 
-	loggerAdapter.Log(ctx, newEntry)
+	loggerAdapter.Log(ctx, entry)
 }
diff --git a/logger/logger.go b/logger/logger.go
@@ -32,17 +32,15 @@ func (l Logger) With(key string, value interface{}) Logger {
 
 // WithError creates a new Logger with error.
 func (l Logger) WithError(err error) Logger {
-	c := l
-	c.entry.Error = err
+	l.entry.Error = err
 
-	return c
+	return l
 }
 
 func (l Logger) WithSkippedCallerFrame() Logger {
-	c := l
-	c.entry.SkippedCallerFrames++
+	l.entry.SkippedCallerFrames++
 
-	return c
+	return l
 }
 
 func (l Logger) Debug(msg string) {