Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws error on storybook 8 #17

Closed
technbuzz opened this issue Aug 9, 2024 · 4 comments · Fixed by #18
Closed

Throws error on storybook 8 #17

technbuzz opened this issue Aug 9, 2024 · 4 comments · Fixed by #18

Comments

@technbuzz
Copy link

As mentioned here storybookjs/storybook#26031 ,

The error I get as follows

node_modules/storybook-addon-deep-controls/index.d.ts:6:8 - error TS2307: 
Cannot find module '@storybook/types' or its corresponding type declarations.

6 } from "@storybook/types";
@eliasm307
Copy link
Owner

@technbuzz I've added @storybook/types as a peer dependency and published v0.6.3, see justification in #18

@technbuzz
Copy link
Author

Now I get different error on version 0.7.0

ERROR in node_modules/.pnpm/[email protected]_@[email protected]_@[email protected][email protected]/node_modules/storybook-addon-deep-controls/index.d.ts:9:8 - error TS2300: Duplicate identifier 'Parameters'.

9   type Parameters = {
         ~~~~~~~~~~

  node_modules/.pnpm/@[email protected]/node_modules/@storybook/core/dist/types/index.d.ts:2:371
    2 export { AnnotatedStoryFn, ArgTypes, ArgTypesEnhancer, Args, ArgsEnhancer, ArgsFromMeta, ArgsStoryFn, BaseAnnotations, Canvas, ComponentAnnotations, ComponentId, ComponentTitle, Conditional, DecoratorApplicator, DecoratorFunction, GlobalTypes, Globals, IncludeExcludeOptions, InputType, LegacyAnnotatedStoryFn, LegacyStoryAnnotationsOrFn, LegacyStoryFn, LoaderFunction, Parameters, PartialStoryFn, PlayFunction, PlayFunctionContext, Renderer, SBArrayType, SBEnumType, SBIntersectionType, SBObjectType, SBOtherType, SBScalarType, SBType, SBUnionType, SeparatorOptions, StepFunction, StepLabel, StepRunner, StoryAnnotations, StoryAnnotationsOrFn, StoryContext, StoryContextForEnhancers, StoryContextForLoaders, StoryContextUpdate, StoryFn, StoryId, StoryIdentifier, StoryKind, StoryName, StrictArgTypes, StrictArgs, StrictGlobalTypes, StrictInputType, Tag } from '@storybook/csf';
                                                                                                                                                                                                                                                                                                                                                                                        ~~~~~~~~~~
    'Parameters' was also declared here.

preview compiled with 1 error

@eliasm307
Copy link
Owner

@technbuzz I've published 0.7.1, let me know if this resolves your issue

@eliasm307 eliasm307 reopened this Aug 13, 2024
@eliasm307
Copy link
Owner

@technbuzz I'll assume no response means the issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants