Chore/add storybook types as peer dependency #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for jade-truffle-8ae50a failed.
|
eliasm307
force-pushed
the
chore/add-storybook-types-as-peer-dependency
branch
from
2a45adc
to
f598ee1
Compare
…//github.com/eliasm307/storybook-addon-deep-controls into chore/add-storybook-types-as-peer-dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Storybook 8 the @storybook/types package doesn't seem to come implicitly from other storybook packages as a peer dependency, from this migration script it looks like the @storybook/types dependency needs to be added explicitly.
The @storybook/types package is not deprecated for Storybook 8 so this PR adds it as a peer dependency and its up to the parent project what version of the types to use.
Fixes #17