Skip to content

Commit

Permalink
Merge pull request #240 from eliasnogueira/refactor
Browse files Browse the repository at this point in the history
Refactor
  • Loading branch information
eliasnogueira authored Jan 28, 2024
2 parents 40978c5 + 1dbf635 commit c0dce57
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 27 deletions.
25 changes: 1 addition & 24 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>com.eliasnogueira</groupId>
<artifactId>selenium-java-lean-test-architecture</artifactId>
<version>3.3.9</version>
<version>3.3.10</version>

<scm>
<connection>scm:[email protected]:eliasnogueira/selenium-java-lean-test-architecture.git</connection>
Expand All @@ -27,7 +27,6 @@
<assertj.version>3.25.2</assertj.version>
<datafaker.version>2.1.0</datafaker.version>
<log4j.version>2.22.1</log4j.version>
<webdrivermanager.version>5.6.3</webdrivermanager.version>
<owner.version>1.0.12</owner.version>
<allure.version>2.25.0</allure.version>
<allure-maven.version>2.12.0</allure-maven.version>
Expand All @@ -37,9 +36,6 @@
</allure.cmd.download.url>
<testcontainers.selenium.version>1.19.4</testcontainers.selenium.version>

<!-- security libraries override -->
<jackson-databind.version>2.16.1</jackson-databind.version>

<suite>local</suite>
</properties>

Expand Down Expand Up @@ -104,18 +100,6 @@
<version>${owner.version}</version>
</dependency>

<dependency>
<groupId>io.github.bonigarcia</groupId>
<artifactId>webdrivermanager</artifactId>
<version>${webdrivermanager.version}</version>
<exclusions>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
<groupId>io.qameta.allure</groupId>
<artifactId>allure-testng</artifactId>
Expand Down Expand Up @@ -146,13 +130,6 @@
<version>${testcontainers.selenium.version}</version>
</dependency>

<!-- security libraries override -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${jackson-databind.version}</version>
</dependency>

</dependencies>

<!-- This profile execute the TestNG suite inside the suites folder on test/resources -->
Expand Down
3 changes: 0 additions & 3 deletions src/main/java/com/eliasnogueira/driver/BrowserFactory.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
package com.eliasnogueira.driver;

import com.eliasnogueira.exceptions.HeadlessNotSupportedException;
import io.github.bonigarcia.wdm.WebDriverManager;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.chrome.ChromeDriver;
import org.openqa.selenium.chrome.ChromeOptions;
Expand Down Expand Up @@ -119,8 +118,6 @@ public EdgeOptions getOptions() {
}, SAFARI {
@Override
public WebDriver createLocalDriver() {
WebDriverManager.safaridriver().setup();

return new SafariDriver(getOptions());
}

Expand Down

0 comments on commit c0dce57

Please sign in to comment.