Skip to content

Update broadway.ex - #366

Merged
whatyouhide merged 4 commits into
elixir-broadway:mainfrom
VigneshwaranSenthilvel:patch-1
Aug 1, 2026
Merged

whatyouhide merged 4 commits into
elixir-broadway:mainfrom
VigneshwaranSenthilvel:patch-1

Conversation

@VigneshwaranSenthilvel

Copy link
Copy Markdown
Contributor

Testing with a specific handle_batch

@josevalim

Copy link
Copy Markdown
Contributor

Can you please update the docs and tests?

@josevalim

Copy link
Copy Markdown
Contributor

Thank you. Although the docs are a bit too thin on the details. Isn't the code in handle_message most likely going to select a batch anyway, overriding this choice? So when would using this option be practical?

PS: also please run mix format.

whatyouhide
whatyouhide previously approved these changes Jan 30, 2026
@whatyouhide
whatyouhide dismissed their stale review January 30, 2026 10:51

Mistaken!

@whatyouhide

Copy link
Copy Markdown
Collaborator

Also, missing an annotation on "Available since ..." or something like that.

@whatyouhide
whatyouhide merged commit d89e098 into elixir-broadway:main Aug 1, 2026
2 checks passed
@whatyouhide

Copy link
Copy Markdown
Collaborator

Thank you @VigneshwaranSenthilvel 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants