Skip to content

Fix off-Broadway list ordering and minor documentation errors #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Sep 17, 2026
Merged

Fix off-Broadway list ordering and minor documentation errors #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion guides/examples/introduction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ The following Off-Broadway libraries are available (feel free to send a PR addin
* [off_broadway_elasticsearch](https://github.com/jonlunsford/off_broadway_elasticsearch): [Guide](https://hexdocs.pm/off_broadway_elasticsearch/)
* [off_broadway_emqtt](https://github.com/intility/off_broadway_emqtt): [Guide](https://hexdocs.pm/off_broadway_emqtt/)
* [off_broadway_kafka](https://github.com/bbalser/off_broadway_kafka): [Guide](https://hexdocs.pm/off_broadway_kafka/)
* [off_broadway_klife (kafka)](https://github.com/oliveigah/off_broadway_klife): [Guide](https://hexdocs.pm/off_broadway_klife/)
* [off_broadway_memory](https://github.com/elliotekj/off_broadway_memory): [Guide](https://hexdocs.pm/off_broadway_memory/)
* [off_broadway_pulsar](https://github.com/efcasado/off_broadway_pulsar): [Guide](https://hexdocs.pm/off_broadway_pulsar/)
* [off_broadway_redis](https://github.com/amokan/off_broadway_redis): [Guide](https://hexdocs.pm/off_broadway_redis/)
* [off_broadway_redis_stream](https://github.com/akash-akya/off_broadway_redis_stream): [Guide](https://hexdocs.pm/off_broadway_redis_stream/)
* [off_broadway_splunk](https://github.com/intility/off_broadway_splunk): [Guide](https://hexdocs.pm/off_broadway_splunk/)
* [off_broadway_klife (kafka)](https://github.com/oliveigah/off_broadway_klife): [Guide](https://hexdocs.pm/off_broadway_klife/)
4 changes: 2 additions & 2 deletions lib/broadway.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,14 +871,14 @@ defmodule Broadway do
* Measurement: `%{duration: native_time}`
* Metadata:

```
```
%{
topology_name: atom,
name: atom,
batcher_key: atom,
telemetry_span_context: reference
}
```
```

Most of the events follow the `:telemetry.span/3` convention for measurements.
This means that "start" events have a `:system_time` representing the start of
Expand Down
2 changes: 1 addition & 1 deletion lib/broadway/config_storage/persistent_term.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ defmodule Broadway.ConfigStorage.PersistentTerm do
def delete(_server) do
# We don't delete from persistent term on purpose. Since the process is
# named, we can assume it does not start dynamically, so it will either
# restart or the amount of memory it uses is negligibla to justify the
# restart or the amount of memory it uses is negligible to justify the
# process purging done by persistent_term. If the repo is restarted and
# stores the same metadata, then no purging happens either.
# :persistent_term.erase({Broadway, server})
Expand Down