Repository navigation
Conversation
Evaluate division and remainder operations together to let the runtime fuse them into a single instruction. Replace manual remainder calculations with rem/2 to remove extra multiplication and subtraction instructions. Assisted-by: Antigravity:Gemini 3.8 Flash
Contributor
Author
|
Assembly lines:
|
Member
|
Thanks but chasing this level of optimization is unlikely to be worth our time investment in most cases! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Antigravity:Gemini 3.8 Flash
If after
div/2we callrem/2then the compiler fuses it to one operation.https://github.com/erlang/otp/blob/master/erts/emulator/beam/jit/x86/ops.tab#L1190-L1213
These changes have been evaluated locally to produce fewer assembly lines and that they run faster.
Bench: