Skip to content

Commit

Permalink
Update .travis.yaml to include the 3 latest elixir versions (#414)
Browse files Browse the repository at this point in the history
* Update .travis.yaml to include the 3 latest elixir versions

* Avoid using `super` in GenServer callbacks

Using `super` in GenServer callbacks was deprecated in elixir 1.7,
to avoid compilation warnings, this commit replaces all calls to
`super` with an explicit return
  • Loading branch information
saulecabrera authored and keathley committed Feb 9, 2019
1 parent c554733 commit bb78231
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
language: elixir
elixir:
- 1.4.5
- 1.5.3
- 1.6.4
- 1.6.6
- 1.7.4
- 1.8.1
otp_release:
- 20.3
env:
Expand Down
4 changes: 2 additions & 2 deletions lib/wallaby/driver/process_workspace/server.ex
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ defmodule Wallaby.Driver.ProcessWorkspace.Server do
File.rm_rf(workspace_path)
{:stop, :normal, state}
end
def handle_info(msg, state), do: super(msg, state)
def handle_info(_, state), do: {:noreply, state}

@impl GenServer
def terminate(:shutdown, %{workspace_path: workspace_path}) do
File.rm_rf(workspace_path)
end
def terminate(reason, state), do: super(reason, state)
def terminate(_, _), do: :ok
end
2 changes: 1 addition & 1 deletion lib/wallaby/phantom/server.ex
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ defmodule Wallaby.Phantom.Server do
def handle_info({port, {:exit_status, status}}, %ServerState{wrapper_script_port: port} = state) do
{:stop, {:exit_status, status}, state}
end
def handle_info(msg, state), do: super(msg, state)
def handle_info(_, state), do: {:noreply, state}

@impl GenServer
def terminate(_reason, %ServerState{wrapper_script_port: wrapper_script_port, wrapper_script_os_pid: wrapper_script_os_pid}) do
Expand Down

0 comments on commit bb78231

Please sign in to comment.