Allow for defining public ips for 1:1 NAT #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karolk99
force-pushed
the
add-map-to-public-ip-function
branch
from
e87a024 to
8248126
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 85.84% 86.06% +0.22%
==========================================
Files 25 25
Lines 1872 1902 +30
==========================================
+ Hits 1607 1637 +30
Misses 265 265
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
mickel8
approved these changes
Jul 23, 2025
mickel8
approved these changes
Jul 23, 2025
| @ipv6 {64_512, 0, 0, 0, 0, 0, 0, 1} | ||
| @invalid_ip :invalid_ip | ||
|
|
||
| test "adds srflx candidate" do |
Contributor
There was a problem hiding this comment.
Actually, all tests except for the first one and the last one could be moved to gatherer_test.exs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mapping function that maps local ip addresses into public ones.
These public addresses are then used to create server reflexive candidates.