Skip to content

Conversation

@sgfn
Copy link
Member

@sgfn sgfn commented Jun 19, 2025

As explained in the comments, checking for nalu_type == 7 with H264 packetization_mode=0 has been verified to work correctly under simulated packet loss conditions.

@sgfn sgfn requested a review from mickel8 June 19, 2025 11:34
@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.55%. Comparing base (9cdd430) to head (5a37aae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files          50       50           
  Lines        2684     2684           
=======================================
  Hits         2350     2350           
  Misses        334      334           
Files with missing lines Coverage Δ
lib/ex_webrtc/peer_connection/configuration.ex 95.05% <100.00%> (ø)
lib/ex_webrtc/rtp/h264.ex 47.05% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdd430...5a37aae. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgfn sgfn force-pushed the fix/h264-pack-mode-0 branch from bef1843 to 5a37aae Compare June 23, 2025 10:54
@sgfn sgfn merged commit 5e20c3d into master Jun 23, 2025
1 check passed
@sgfn sgfn deleted the fix/h264-pack-mode-0 branch June 23, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants