Remove stacktrace warning #242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamvery
approved these changes
Jun 10, 2020
iamvery
reviewed
Jun 10, 2020
lib/execute.ex
Outdated
| defp expand(error, module) do | ||
| {file, line} = | ||
| System.stacktrace() | ||
| :erlang.get_stacktrace() |
Collaborator
There was a problem hiding this comment.
This will have to be rebased due to a change in #251
|
FWIW, this is not going to work on recent OTP versions. Erlang/OTP 23 always returns an empty list for stacktrace and the next version will fully remove the function. |
Collaborator
Author
|
@josevalim @iamvery My current thinking is that we can avoid going through the stacktrace to find file & line if we just capture them in the generated I'll try a PR this evening and update this :) |
felipesere
force-pushed
the
stacktrace-warnings
branch
from
67198dc to
2c4e1f5
Compare
Collaborator
Author
|
I'm quite happy with this new approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using STACKTRACE is not really an option due to it requiring a
try/catch block, which we'd have to possibly add to every koan.
Side-step the issue by calling into Erlang