Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set correct disabled property in <a> tag in SettingsItem #2770

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: set correct disabled property in <a> tag in SettingsItem #2770

wants to merge 1 commit into from

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Apr 6, 2024

ref. #2767

@stackblitz StackBlitz
Copy link

stackblitz bot commented Apr 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify Netlify
Copy link

netlify bot commented Apr 6, 2024 •
edited
Loading

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 1774107
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/66f5014d41ba590008831310

@netlify Netlify
Copy link

netlify bot commented Apr 6, 2024 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 1774107
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/66f5014d3db86e0008e9bd03
😎 Deploy Preview https://deploy-preview-2770--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3
Copy link
Member Author

shuuji3 commented Apr 6, 2024 •
edited
Loading

Maybe this is a different issue. I couldn't reproduce disabled="false" rendering with the clean installation of [email protected]:
https://stackblitz.com/edit/nuxt-starter-9e9zdh?file=app.vue

We need to check why :disable="false" does not remove the disable property and it is rendered as disable="false" instead.

@shuuji3 shuuji3 marked this pull request as draft April 12, 2024 06:48
@shuuji3 shuuji3 force-pushed the shuuji3/fix/invalid-disabled-prop branch from 371c74d to 1774107 Compare September 26, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shuuji3