fix(ui): hide account lock icon on status card in timeline #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuuji3
force-pushed
the
shuuji3/fix/hide-account-lock-icon-in-status-card
branch
from
48e0676
to
6fec751
Compare
shuuji3
changed the title
|
To me it's more about the position of the icon. I think if the lock is for the account it should be visible & closer to the name/profile picture. Then maybe we can also show consistently in different profile views? I wonder if we could have two rows in the status card similar as in the profile page... the name + icons (at top) and username (bottom) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2492
As explained in the original issue, showing the account lock 🔒 icon on the status card is quite confusing:
I think this decision in the official Mastodon UI is reasonable because the meaning of 🔒 icon on Mastodon differs from that on Twitter.
On Twitter, 🔒 icon for the account has two meanings at the same time: the account requires to follow requests, and the visibility of all the posts is limited to "Only follower". So showing 🔒 icon on the status makes sense.
On the other hand, on Mastodon, the visibility of posts and account following limitations are separated. And the locked account still can publish publicly visible posts so 🔒 icon only indicates that the following approval is required when someone is following.
Mastodon already has the icon for visibility on the post (such as 🌎 and 🔒) so it should be enough to show 🔒 icon only on the account page (or other account-specific component) where users need to know whether the account requires the following request or not.
Although Mastodon UI doesn't show the bot icon too, I think we can keep it because the bot icon can show both meanings: the account is automated and the post itself is programmatically published by the bot.
After
The status detail page still shows the lock indicator as the visibility indicator is clearly separated in different places without confusion.
Another example with the lock icon: