Parse quote identifiers #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tagging @elliottt for a review |
elliottt
approved these changes
Sep 5, 2023
Comment on lines
+409
to
+411
| // NOTE(rachitnigam): Not sure if this is the best way to signal an | ||
| // error in the lexer. | ||
| assert!(!quoted, "unterminated | in symbol"); |
There was a problem hiding this comment.
Good point! We didn't really have any parse errors before, given how permissive the symbol parsing was, so it would be nice to revisit that in a follow-up PR.
There was a problem hiding this comment.
Yeah, some simple API to report the errors would be useful!
Comment on lines
+393
to
+397
| } else if *c == '|' { | ||
| // If we see a quote, toggle the quoted flag. | ||
| quoted = !quoted; | ||
| self.indices.next(); | ||
| continue; |
There was a problem hiding this comment.
Is it possible to escape the quotes? If not, this state machine seems reasonable to me 👍
There was a problem hiding this comment.
I don't think so? The quoted identifiers are specified as not containing | so I imagine you can't escape but I am also new to the feature.
|
Can we do a new release once this is merged? |
elliottt
added a commit
that referenced
this pull request
Sep 5, 2023
Minor version bump to include the bug fix in #24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23.