Refactor affiliate linking. #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a struct to define the state of our original to affiliated transformation we reveal more about our intentions.
| @@ -0,0 +1,9 @@ | |||
| defmodule ElloClick.Affiliate.Link do | |||
| defstruct [original: nil, affiliated: nil, is_affiliated: false] | |||
There was a problem hiding this comment.
Is it worth expanding out the names of these fields a bit as long as we're trying to be extra-clear (e.g. original_link, affiliated_link)? Not sure if it's idiomatic, just a thought.
There was a problem hiding this comment.
I don't mind the shorter names. Since they are in a Link struct the "link" prefix is not needed. Not sure what you think @alanpeabody.
There was a problem hiding this comment.
I tend towards brevity in variable names, but happy to update to add them.
There was a problem hiding this comment.
We were actually thinking this could even be taken a little further and have those be %URI{} structs so we could match on hostname without schema easier.
michelegera
force-pushed
the
main
branch
3 times, most recently
from
b7ec6d3
to
14ce02f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a struct to define the state of our original to affiliated
transformation we reveal more about our intentions.