added transpose #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. I'll take a closer look at the implementation later, but would you mind adding some examples as a doc string? Examples with matrices of varying dimensions and types would be nice. |
|
If we do, we should consider how to handle non-rectangular 2d arrays: elm-community/list-extra#83 (comment) |
|
So maybe just add this PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use transpose a lot, because I use 2D arrays a lot when writing games in Elm, so I think transpose is justified. According to an SO question on JS's array length, length's time complexity should be constant, so there should be no performance problems with using array length in code.