This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Range datepicker#66
Open
annistone wants to merge 12 commits intoelm-community:masterfrom
Open
Conversation
Collaborator
|
Wow! I'm super impressed. I'm reluctant to merge this for one reason (that has nothing to do with the great work you did): the repo would take on responsibility for maintaining a lot more functionality that it has now--so, we'd have to ensure that the range picker is not broken by changes, etc etc. Since the Elm community is not planning to host a datepicker at all in 0.19, it seems like a large expansion. But! I don't want your work to be wasted. Here are some options I can think of; what are your feelings? What if this were a separate Elm package that uses |
|
@annistone awesome work! I've forked and merged your PR to use it in a project! Thanks for this https://github.com/regalii/elm-datepicker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I made a date picker inspired be https://longbill.github.io/jquery-date-range-picker/. It looks like this:
It's my first elm pull request, so I am not sure that I did it right way.
I made API compatible with old RangePicker, but moved mine to the new module.
So there new RangeDatePicker.elm and elm-range-datepicker.css and example range2( I'm not sure how to name it because range example already exists).
Related issue: #51