This repository has been archived by the owner on Oct 5, 2024. It is now read-only.
Added GLSL parser #115
Open
Added GLSL parser #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janiczek
reviewed
Aug 15, 2020
Janiczek
reviewed
Aug 15, 2020
Janiczek
reviewed
Aug 15, 2020
| @@ -406,6 +406,10 @@ shrinkExpr expr = | |||
| -- TODO take a stab at this? Do we actually even generate these? | |||
| nope | |||
|
|
|||
| CanonicalU.Shader _ -> | |||
| -- TODO take a stab at this? Do we actually even generate these? | |||
There was a problem hiding this comment.
I wonder if we would have to make well-defined GLSL programs here. Let's leave it as it is right now 👍
|
Looks good so far! I'm curious to see how the shader type turns out! Don't hesitate to ask on Discord if you want help with generating the type equations :) (Type inference tests will be the most interesting and important part here I believe.) |
|
added two more examples to the shader parser tests, based of https://github.com/elm-explorations/webgl/blob/81527c23ba21d9bf92f34151a6a4c40a68460e1f/examples/Triangle.elm#L77-L105 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial implementation for the WebGL Shader (GLSL) parser.