Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add elm-analyse schema #199

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Add elm-analyse schema #199

merged 1 commit into from
Aug 12, 2021

Conversation

razzeee
Copy link
Member

@razzeee razzeee commented Jul 11, 2021

@razzeee razzeee requested a review from jmbockhorst July 11, 2021 14:03
@razzeee
Copy link
Member Author

razzeee commented Jul 15, 2021

We might not want to do this, but do elm-tooling/elm-language-server#616 instead.

@jmbockhorst
Copy link
Member

I agree.

@lydell
Copy link
Member

lydell commented Jul 18, 2021

If the schema in this PR is correct, maybe merge anyway since it adds value until the config is moved?

@razzeee
Copy link
Member Author

razzeee commented Jul 20, 2021

It would, but that would have to be released, to add value.

@razzeee razzeee merged commit 5aa074d into main Aug 12, 2021
@razzeee razzeee deleted the type-elm-analyse branch August 12, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmbockhorst jmbockhorst Awaiting requested review from jmbockhorst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razzeee @jmbockhorst @lydell