Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added many more MIME types #2059

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added many more MIME types #2059

wants to merge 1 commit into from

Conversation

Anton-4
Copy link

@Anton-4 Anton-4 commented Feb 7, 2020

should fix some file contents being erroneously wrapped in HTML when using reactor #1972

Quick Summary: Reactor served some file contents wrapped in html. This occurred for me when using csv files and made it difficult to use reactor for my application. Others have experienced this problem as well for other file types, see #1972 .
I added many mime types so certain files would no longer be returned as html. I did not yet test my new code because I could not find instructions on how to build elm. I will gladly perform testing given the necessary instructions

SSCCE

  1. In an elm project, put any csv file in assets folder
  2. elm reactor
  3. wget http://localhost:8000/FILE_NAME.csv will return the file contents with lines of html added.
  • Elm: 0.19.1
  • Browser: firefox 72.0.1 (64-bit)
  • Operating System: KDE Neon 5.17 > Ubuntu 18.04

@gcoakes
Copy link

gcoakes commented Oct 12, 2020

I'm not a contributor to this project or anything, but @Anton-4 , it looks like you can compile elm by running docker build -t elm -f installers/linux/Dockerfile . from the project root. That will create a docker image which contains the compiled version of elm at /usr/local/bin/elm. It seems like a really weird way to build it when you could also just run cabal build, but that's how it's done in the .travis.yml.

@Anton-4
Copy link
Author

Anton-4 commented Oct 13, 2020

Thanks for the tip, I'll make sure to give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants