Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix JavaScript BigInt mapping to BigInteger serialization incorrect #6164

Merged

Conversation

fanslead
Copy link
Contributor

@fanslead fanslead commented Nov 29, 2024

#6163


This change is Reviewable

@MrHPotter
Copy link

Maybe a Test Serializing and Deserializing with an Options Object Created with this Converter included, would be nice, to prove it works as expected. (and keep it working in the future)

@fanslead
Copy link
Contributor Author

fanslead commented Dec 2, 2024

Maybe a Test Serializing and Deserializing with an Options Object Created with this Converter included, would be nice, to prove it works as expected. (and keep it working in the future)

@MrHPotter You're right, I've already added testing

Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍🏻

@sfmskywalker sfmskywalker merged commit 5ac63f1 into elsa-workflows:main Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants