Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve variable parsing with error handling and logging #6207

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

sfmskywalker
Copy link
Member

@sfmskywalker sfmskywalker commented Dec 12, 2024

Added TryParseValue method to handle parse errors gracefully and prevent crashes. Updated VariablePersistenceManager to log warnings when variable parsing fails, providing better debugging support and resilience during workflow execution.


This change is Reviewable

Added `TryParseValue` method to handle parse errors gracefully and prevent crashes. Updated `VariablePersistenceManager` to log warnings when variable parsing fails, providing better debugging support and resilience during workflow execution.
Updated the exception message to use the full type name of the variable, providing clearer details for debugging type compatibility issues during variable value parsing.
@sfmskywalker sfmskywalker linked an issue Dec 12, 2024 that may be closed by this pull request
Updated the log message to use the full variable type name instead of the base type. This provides more detailed context for debugging failed variable parsing issues.
@sfmskywalker sfmskywalker merged commit cc75bb6 into main Dec 12, 2024
2 of 4 checks passed
@sfmskywalker sfmskywalker deleted the bug/6193 branch December 12, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Variable API throws BadRequest when type mismatch
1 participant