Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workflow runtime structure and update handlers #6260

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

sfmskywalker
Copy link
Member

@sfmskywalker sfmskywalker commented Jan 2, 2025

Moved CancelWorkflowsCommandHandler to the shared runtime module. Updated related project references, features, and configurations accordingly. Improved WorkflowInstance actor to save state using IWorkflowInstanceManager.


This change is Reviewable

Moved `CancelWorkflowsCommandHandler` to the shared runtime module. Updated related project references, features, and configurations accordingly. Improved `WorkflowInstance` actor to save state using `IWorkflowInstanceManager`.
Enhanced the workflow cancellation process by saving the updated workflow state using `IWorkflowInstanceManager`. Similar updates were applied to state import logic to ensure consistency in persisting workflow state changes.
@sfmskywalker sfmskywalker linked an issue Jan 2, 2025 that may be closed by this pull request
@sfmskywalker sfmskywalker merged commit 106c335 into main Jan 2, 2025
4 checks passed
@sfmskywalker sfmskywalker deleted the bug/6258 branch January 2, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cancelling suspended workflow does not work in 3.3.0 RC5
1 participant