Skip to content

Upgrade Cypress v6 -> v13#3275

Merged
lresende merged 1 commit intoelyra-ai:mainfrom
caponetto:cp-odh-pr-93
Jan 13, 2025
Merged

Upgrade Cypress v6 -> v13#3275
lresende merged 1 commit intoelyra-ai:mainfrom
caponetto:cp-odh-pr-93

Conversation

@caponetto
Copy link
Copy Markdown
Contributor

@caponetto caponetto commented Jan 13, 2025

What changes were proposed in this pull request?

Upgrade Cypress v6 -> v13

Cherry-picked from opendatahub-io#93

How was this pull request tested?

Through CI runs

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@caponetto caponetto requested a review from lresende January 13, 2025 13:08
@lresende
Copy link
Copy Markdown
Member

@caponetto Are all the tests and other artifacts inside tests only applicable to Cypress?

@caponetto
Copy link
Copy Markdown
Contributor Author

@caponetto Are all the tests and other artifacts inside tests only applicable to Cypress?

Yes. The only thing is that Jest was sharing the same tsconfig.json with Cypress, which could lead to some issues. Now, Jest has its own tsconfig.jest.json.

@lresende
Copy link
Copy Markdown
Member

@caponetto could you resolve the conflicts please

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
@lresende lresende merged commit 54e2e9d into elyra-ai:main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants