Allow nicks to be colored based on their hash #397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new variable
circe-color-nicks-persist
which causes nicknames to be colored by using their hash as an index intocirce-nick-color-pool
.There are a couple of minor foibles:
Changing the signature of
circe-nick-color-pick
breaks backwards-compatability, I have looked around and not found anyone who actually used this anywhere, so I don't think it's a major problem, could be solved by making the new argument optional.Changing
circe-color-nicks-persist
after some nicks have been popped from the pool reduces the available colors, but I don't imagine people flip-flopping the setting often.