Skip to content

Commit

Permalink
Fix 404 error when attempting to download OpenVSX extensions (#762)
Browse files Browse the repository at this point in the history
This change fixes this error when running `(dap-node-setup)`:
`url-insert-file-contents: https://open-vsx.org/api/ms-vscode/node-debug2/latest/: Not found`

The problem was that the OpenVSX URL template string had a trailing
slash, which is not handled by OpenVSX's Registry API Controller:
https://github.com/eclipse/openvsx/blob/master/server/src/main/java/org/eclipse/openvsx/RegistryAPI.java#L348

I can't really find a blame in the OpenVSX repo which could've caused
the extraneous trailing slash. Maybe the update to Java 17?

As you can see, there's no trailing slash at the end, so the route
doesn't get mached in the controller and causes a 404 Not Found.

Just removing the slash does the job and `(dap-node-setup)` runs successfully.

References:
- #554 (comment)
- #700
  • Loading branch information
sethidden authored Nov 10, 2023
1 parent 1187c69 commit f6706fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dap-utils.el
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
:type 'string)

(defcustom dap-utils-openvsx-extension-api-url
"https://open-vsx.org/api/%s/%s/%s/"
"https://open-vsx.org/api/%s/%s/%s"
"Open VSX extension api url."
:group 'dap-utils
:type 'string)
Expand Down

0 comments on commit f6706fa

Please sign in to comment.