Add basic pull diagnostics support #4280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you resolve conflicts and rebase this? Thank you! |
Ruin0x11
force-pushed
the
feature/pull-diagnostics
branch
from
8501368
to
d64a217
Compare
|
The newest version of eslint plugin also uses the feature. My project using latest eslint version 9.5.0, it doesn't work with eslint plugin version 2.2.2 which is lastest version lsp-eslint provided. So I downloaded the latest eslint plugin from vscode market and replaced it, but it not work. Then I applied the patch, it worked. It would be great if some can review and merge the code. |
|
@jcs090218 Could you please take a look at this when you have some time? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only basic support for now; no extra features like related documents. It's just enough to get diagnostics showing with the Roslyn server.
Closes #4276.