Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: do not overwrite lsp-client-settings changed by user #4421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Apr 8, 2024

  1. treewide: do not overwrite lsp-client-settings changed by user

    If a user has set a setting inside `lsp-client-settings`, changing its
    value will result in a silent bug in user configuration that looks
    like a regression from `lsp-mode` mode update. Let's avoid that by
    adding a new function `lsp-register-new-settings` that avoids
    overwritting whatever was set by user and make use of it treewide.
    
    While at it, prohibit `lsp-register-custom-settings` from internal use
    for all the same reasons.
    
    Fixes: emacs-lsp#4420
    Hi-Angel committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    03d89dd View commit details
    Browse the repository at this point in the history