Remove Alire support from lsp-mode Ada client. #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
approved these changes
Jun 26, 2024
Alire support is now available directly in the Ada Language Server and handles the functionality currently implemented in lsp-mode. In addition, when the project file is not specified by the LSP client, the language server will intelligently locate the project file using `alr` when an Alire configuration file exists. Therefore, the default setting of the project file has been changed (from "default.gpr" to nil) to enable the server to automatically locate the project file in normal situations. The server will also automatically find a project file for a non-Alire project if it uniquely exists in the root folder (i.e., no other project file exists in this folder). The new project file default setting provides for a better out-of-the-box configuration to support common situations.
brownts
force-pushed
the
bugfix/remove-alire
branch
from
4e3730b
to
753c931
Compare
|
Moved the safety predicate for the lsp-defcustom to an autoload, so that it's available during .dir-locals.el processing, which occurs prior to the lsp package being loaded in hack-local-variables-hook. |
jcs090218
approved these changes
Jun 28, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alire support is now available directly in the Ada Language Server and handles the functionality currently implemented in lsp-mode. In addition, when the project file is not specified by the LSP client, the language server will intelligently locate the project file using
alrwhen an Alire configuration file exists. Therefore, the default setting of the project file has been changed (from "default.gpr" to nil) to enable the server to automatically locate the project file in normal situations. The server will also automatically find a project file for a non-Alire project if it uniquely exists in the root folder (i.e., no other project file exists in this folder). The new project file default setting provides for a better out-of-the-box configuration to support common situations.See discussion #4468 for additional details.