Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MATLAB language server #4611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohnC32
Copy link
Contributor

@JohnC32 JohnC32 commented Nov 12, 2024

This adds support for the MATLAB Language Server, https://github.com/mathworks/MATLAB-language-server

@github-actions github-actions bot added documentation client One or more of lsp-mode language clients labels Nov 12, 2024
@JohnC32
Copy link
Contributor Author

JohnC32 commented Nov 12, 2024

I see 2 checks failed. I looked an they seem to be unrelated to my changes. They are:

In toplevel form:
lsp-completion.el:187:16: Error: ‘when-let’ is an obsolete macro (as of 31.1); use ‘when-let*’ or ‘and-let*’ instead.
...........................Test lsp-byte-compilation-test backtrace:


Test lsp-byte-compilation-test condition:

    (ert-test-failed
     ((should (byte-compile-file library)) :form
      (byte-compile-file
       "/Users/runner/work/lsp-mode/lsp-mode/lsp-completion.el")
      :value nil))

@jcs090218
Copy link
Member

I see 2 checks failed. I looked an they seem to be unrelated to my changes. They are:

Yeah, those are unrelated. There's no need to worry about it.

@jcs090218
Copy link
Member

Can you update docs/lsp-clients.json as well? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants