fix(graphql): Prevent the graphql server from accidentally starting with a TypeSpec file #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduce a situation where GraphQL is unintentionally reacting to a TypeSpec file (`.tsp`).
Do not mistakenly assume that `.tsp` is a file containing GraphQL.
jcs090218
approved these changes
Dec 13, 2024
|
Oops, I merged #4686 before this PR. Can you check to see if that works? I would still like to merge the test file. |
The following person's method was used for the lsp-graphql match method. [lsp-graphql: fix regexp for ext check by suzuki · Pull Request emacs-lsp#4686 · emacs-lsp/lsp-mode](emacs-lsp#4686) Since the final matching is done by regular expressions, I thought it would be more consistent to use regular expressions rather than Lisp programs to make decisions as much as possible.
|
@jcs090218 |
jcs090218
approved these changes
Jan 27, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension determination was not accurate and reacted to `.tsp' files.
Created a unit test case to the function that performs the extension determination and modified the actual code.