Investigate elide lifetimes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petekubiak
approved these changes
Nov 8, 2024
|
Please revert all the formatting changes other than the lifetime changes (there are changes in some of the macros, the hex capitalization issue, some parentheses that went missing). This PR should only touch the lifetime issues flagged by clippy. Thanks! |
|
Will do tomorrow! Thanks @alexmoon :) |
|
@alexmoon That should be everything formatted correctly now, only changes on the PR are the lifetimes and the formatting around it :) |
lulf
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focused on getting rid of clippy nightly warnings based on redundant lifetimes. It aims to solve the issue listed in #21.
I did find that I had to turn my format on save off when doing this PR as it would break my imports in some of the files resulting in a mess of errors.
The code still builds in both nightly and stable and clippy no longer has any warnings in either stable or nightly :)