Fix field deduplication#129
Draft
inferiorhumanorgans wants to merge 2 commits intoembassy-rs:mainfrom
Draft
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
This does enforce deduplication at the SVD ↔ IR boundary, no? |
Contributor
|
Hm, yeah, I'm sorry: I don't really know how I convinced myself that this was doing something else... I've hidden my comment for now. Though 134 does (I think?) also fix this problem, my comment is outdated/off-topic/just wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#93 actually missed the part of the code where the field itself is named. This PR ensures fields are renamed.
This is marked as a draft because I added a couple tests to define the expected behavior. Beyond making sure that this is the right shape for tests to take, the
duplicate_ir_fields_should_not_collidetest fails. Should deduplication happen when parsing SVD and YAML definitions or just SVDs?