Skip to content

remove portable-atomic #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dirbaio merged 1 commit into from
Mar 1, 2024
Merged

remove portable-atomic #2242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions embassy-executor/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ critical-section = "1.1"

document-features = "0.2.7"

# needed for riscv and avr
# remove when https://github.com/rust-lang/rust/pull/114499 lands on stable (on 1.76)
# needed for AVR
portable-atomic = { version = "1.5", optional = true }

# arch-cortex-m dependencies
Expand Down Expand Up @@ -78,7 +77,7 @@ arch-std = ["_arch", "critical-section/std"]
## Cortex-M
arch-cortex-m = ["_arch", "dep:cortex-m"]
## RISC-V 32
arch-riscv32 = ["_arch", "dep:portable-atomic"]
arch-riscv32 = ["_arch"]
## WASM
arch-wasm = ["_arch", "dep:wasm-bindgen", "dep:js-sys"]
## AVR
Expand Down
2 changes: 1 addition & 1 deletion embassy-executor/src/arch/riscv32.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ pub use thread::*;
#[cfg(feature = "executor-thread")]
mod thread {
use core::marker::PhantomData;
use core::sync::atomic::{AtomicBool, Ordering};

pub use embassy_executor_macros::main_riscv as main;
use portable_atomic::{AtomicBool, Ordering};

use crate::{raw, Spawner};

Expand Down