embassy-executor 0.4#2254
Merged
Dirbaio merged 2 commits intoembassy-rs:mainfrom Dec 6, 2023
jessebraham:executor-040
Merged
Conversation
lulf
approved these changes
Dec 5, 2023
Member
lulf
left a comment
There was a problem hiding this comment.
LGTM just minor comment on the changelog
Member
|
Could you add this to changelog too? sorry I forgot |
Contributor
Author
Ahh my bad, wasn't aware of that issue and was just blindly following the comment in the manifest 😁 |
Contributor
Author
|
Sorry, didn't notice that CI was red yesterday. Have updated all references to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not really sure what the full release process is, but this is at least working with
esp-hal. If you would like any further changes made please let me know and I'm happy to make them.