feat: Extended the Scan API #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested it, works! |
Dirbaio
reviewed
Dec 15, 2023
cyw43/src/control.rs
Outdated
| @@ -1,5 +1,6 @@ | |||
| use core::cmp::{max, min}; | |||
| use core::iter::zip; | |||
| use core::time::Duration; | |||
There was a problem hiding this comment.
please use embassy_time::Duration instead.
(core::time::Duration is a bit bloated for embedded usage: it has u64 seconds + u32 nanoseconds, and requires expensive multiply/divide by 10^9 when doing math with it)
Dirbaio
reviewed
Dec 15, 2023
cyw43/src/control.rs
Outdated
| }, | ||
| Passive { | ||
| /// Period of time to wait on each channel when passive scanning. | ||
| dwell_time: Option<Duration>, |
There was a problem hiding this comment.
maybe dwell_time could be a field in ScanOptions instead, since the two scan types have it equally?
Dirbaio
force-pushed
the
extend-cyw43-bss-info
branch
from
c780b58 to
6ca4303
Compare
|
I've backed out the BssInfo changes because they ended up conflicting with #2461 , i'm merging the rest. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have extended the scan APIs. I followed the mentioned reference implementation.
It is not tested though and it would be very kind if someone could before merging, my debug probe hasn't arrived yet.