Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add low-power feature for stm32l5 #2375

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

chrenderle
Copy link
Contributor

The ci pipeline is currently not compiling stm32l5 with the low-power feature activated like for the stm32l0 for example. I was wondering why the ci tests were still successful for #2368 even though the registers are not merged in stm32-data (embassy-rs/stm32-data#325). This should change it and only make embassy compile for stm32l5 with the low-power feature when the registers are merged in stm32-data.

@Dirbaio
Copy link
Member

Dirbaio commented Jan 1, 2024

LGTM. Now that embassy-rs/stm32-data#325 is merged you can update stm32-metapac in Cargo.toml (in 2 places, be careful!)

@chrenderle
Copy link
Contributor Author

Thanks, will do it in the next days together with the stop support.

@chrenderle chrenderle marked this pull request as draft January 2, 2024 22:09
@chrenderle chrenderle marked this pull request as ready for review January 2, 2024 22:10
@chrenderle
Copy link
Contributor Author

How can I retrigger the checks for this PR? They should now pass with #2387 merged.

@Dirbaio
Copy link
Member

Dirbaio commented Jan 2, 2024

rebase and force-push (tests on a branch run on the branch, not on the result of merging it on main. the result of merging is tested in the merge queue after approval)

@Dirbaio Dirbaio merged commit b0b59d8 into embassy-rs:main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants