feat: nrf52/pdm+saadc: Add zero-copy, dynamic double buffered continuous sampling #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lulf
reviewed
Mar 21, 2024
embassy-nrf/src/pdm.rs
Outdated
Comment on lines
392
to
397
| /// SAFTEY: | ||
| /// It is expected that the caller will set the length to non-zero and re-use the same | ||
| /// length and capacity for each buffer. Changing buffer sizes is not supported. | ||
| /// | ||
| /// At least one buffer will still be allocated when the function returns. The caller | ||
| /// should call free it to prevent leaks. |
There was a problem hiding this comment.
Maybe it makes sense to add some assertions to ensure this invariant is met? (Non-zero at least).
ALso SAFTEY -> SAFETY
trueb2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pdm_continuous_zero_copy example and fixes documentation in the pdm_continuous example. I left the existing interface because it is easier to use and looks safer despite the timing issues.
I use this with embedded-alloc TlfsHeap to do math that may take longer than the amount of time to fill a buffer. With the Vec interface, I can zero-copy send the owned data to a channel and receive the owned data on a lowest priority executor task.
I could add the embedded-alloc crate and dynamic allocation to this example, but static buffers are sufficient to use the API.