Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWM Improvements #2487

Merged
merged 2 commits into from
Jan 29, 2024
Merged

PWM Improvements #2487

merged 2 commits into from
Jan 29, 2024

Conversation

Murmele
Copy link
Contributor

@Murmele Murmele commented Jan 27, 2024

  1. implement retriving the current duty
  2. Do not wait for seqend if the pwm is disabled, because then an infinity loop occurs

I will finish implementing my driver (Driving a Buzzer) to see if I have more improvements

@Murmele
implement retriving duty.
b08a095 
Description: When disabling the pwm and enabling again, it is required to restart the sequence. If the previous duty is not known, it is not possible to turn on the pwm again
@Murmele
Do not wait when the pwm is disabled
319b0fe 
Reason: because in this case no seqend event is raised and therefore an infinity loop occurs
@Murmele Murmele marked this pull request as ready for review January 29, 2024 07:47
Dirbaio
Dirbaio approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Dirbaio Dirbaio added this pull request to the merge queue Jan 29, 2024
Merged via the queue into embassy-rs:main with commit 6813931 Jan 29, 2024
9 checks passed
@Murmele
Copy link
Contributor Author

Murmele commented Jan 29, 2024

Thanks for merging

@Murmele Murmele deleted the pwm branch June 13, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Murmele @Dirbaio