Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32WBA's high speed external clock has to run at 32 MHz #2511

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Ecco
Copy link
Contributor

@Ecco Ecco commented Feb 1, 2024

STM32WBA's HSE speed cannot be configured: it has to run at 32 MHz.

I'm not sure the PllSource enum is still needed at this point but since this is my first contribution I went for something minimal. Let me know if PllSource should just go.

As a side note, because their frequencies are fixed, the datasheet of that chip refers to the high-speed clocks as HSI16 and HSE32. I'd be willing to contribute a change in that direction if it'd be useful.

@Ecco Ecco force-pushed the stm32wba-fixed-hse branch from 6a6d0b7 to aa76727 Compare February 1, 2024 18:42
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Dirbaio
Copy link
Member

Dirbaio commented Feb 1, 2024

I'm not sure the PllSource enum is still needed at this point but since this is my first contribution I went for something minimal. Let me know if PllSource should just go.

doesn't really matter since PLL support is WIP... when it's done they'll be different though, because ClockSrc can point to PLL while PllSrc can't.

As a side note, because their frequencies are fixed, the datasheet of that chip refers to the high-speed clocks as HSI16 and HSE32. I'd be willing to contribute a change in that direction if it'd be useful.

we used the HSI16 name a while ago to match ST naming, and it became annoying to cfg HSI/HSI16 depending on the chip, so I intentionally renamed everything to HSI. HSE/HSE32 would be the same.

@Dirbaio Dirbaio added this pull request to the merge queue Feb 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 1, 2024
@Dirbaio Dirbaio added this pull request to the merge queue Feb 1, 2024
Merged via the queue into embassy-rs:main with commit c4839e4 Feb 1, 2024
6 checks passed
@Ecco Ecco deleted the stm32wba-fixed-hse branch February 1, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants