boot: flash-erase-zero feature for compatibility with STM32L0x1 devices#3344
Merged
Dirbaio merged 1 commit intoembassy-rs:mainfrom Sep 16, 2024
Merged
boot: flash-erase-zero feature for compatibility with STM32L0x1 devices#3344Dirbaio merged 1 commit intoembassy-rs:mainfrom
Dirbaio merged 1 commit intoembassy-rs:mainfrom
Conversation
Allow compatibility with devices whose flash erase set bytes to 0x00 instead of 0xFF, using a new flash-erase-zero feature. See issue embassy-rs#3342.
lulf
approved these changes
Sep 16, 2024
Member
lulf
left a comment
lulf
left a comment
There was a problem hiding this comment.
Thanks for fixing. This used to work using a generic param to embassy-boot, but it appears that has been lost in refactorings. I think using a feature flag is a less intrusive way to handle this, so lgtm!
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
i404788
pushed a commit
to i404788/embassy
that referenced
this pull request
Mar 23, 2025
Allow compatibility with devices whose flash erase set bytes to 0x00 instead of 0xFF, using a new flash-erase-zero feature. See issue embassy-rs#3342.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for issue #3342, subject for discussion. Any feedback is welcome.
Allow compatibility with devices whose flash erase set bytes to 0x00 instead of 0xFF, using a new flash-erase-zero feature.