Added remove_if to priority channel

[Gibbz]

Added remove_if to priority channel. This allows removing items from the queue if there is a match in the predicate.
You can also do this on a sender, receiver and the channel directly itself.

In my sample code I use the following:

let send_ble_queue = QUEUE_CHANNEL.sender();
send_ble_queue.remove_if(|i| { i.handle == handle && i.is_single_instance() });

This is for my issue here: #3431

[Dirbaio]

• It feels wrong that the sender can remove items from the channel. Ideally the sender should only be able to add, the receiver should only be able to remove.
• I'm not sure about the feature, it feels a bit ad-hoc to your particular use case. If you need to dedup maybe you want global bools or signals denoting "does X need to be done?" instead of a queue, that will dedup "for free"

[Gibbz]

Can you give me a bit more information on how you would implement your second point?

I'm using the que as some items need to sent in order, such as multiple log events.

Most everything else simply needs priority. And these items really only need to send the latest information, so the older information can be dropped off it had not been sent yet.

Is this something you want to merge, or should I just implement it specifically for my project?

[lulf]

Filtering/selectors are not unusual when using queues, but I think this should only be on the receiver end. One alternative is to use one queue per case you wish to filter on. On the sender side you can anyway filter before you push so there's not really a need for additional APIs there.

[lulf]

To be clear, what I think would make sense is:

let item = receiver.receive_with_filter(|i| i.priority == 0).await;

[Gibbz]

Okay thanks. I'll update the pr soon 👍

[Gibbz]

I've updated this removing the sender from using the function. It doesn't seem to be building for some reason. Any idea why this is getting stuck?

@Dirbaio