Use cyw43 FW file size instead of magic numbers #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bender run |
|
cyw43 HIL test is failing for some reason. Also I don't remember whether the pico w in CI has the latest firmware flashed. if the size doesn't match it's because it has an older one, in which case changing it will break it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remove the possibility of the firmware slice length being incorrect when the firmware is updated next time.
Would be nice to also have a test that runs the bluetooth firmware so we can have an assert that the firmware blobs don't overlap - I don't expect this to be a serious concern though.
Resolves #3470