embassy-usb: fix core::intrinsics deprecate warning in nightly.#3841
Merged
Dirbaio merged 1 commit intoembassy-rs:mainfrom Feb 3, 2025
Merged
embassy-usb: fix core::intrinsics deprecate warning in nightly.#3841Dirbaio merged 1 commit intoembassy-rs:mainfrom
core::intrinsics deprecate warning in nightly.#3841Dirbaio merged 1 commit intoembassy-rs:mainfrom
Conversation
Replaced `core::intrinsics::copy_nonoverlapping` with the `core::ptr::copy_nonoverlapping`. Compiling embassy-usb v0.4.0 (embassy/embassy-usb) warning: use of deprecated module `core::intrinsics`: import this function via `std::mem` instead --> embassy/embassy-usb/src/class/cdc_ncm/mod.rs:17:23 | 17 | use core::intrinsics::copy_nonoverlapping; | ^^^^^^^^^^^^^^^^^^^
Dirbaio
approved these changes
Feb 3, 2025
Member
Dirbaio
left a comment
Dirbaio
left a comment
There was a problem hiding this comment.
oops, we've been a victim of rust-analyzer autocomplete here, I think :)
thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems changed in Rust rust-lang/rust#135003.
The compiler suggest to use
core::mem::copy_nonoverlapping.But that seems not exists so I used
core::ptr::copy_nonoverlappingwhich is used in other parts in Embassy.Replaced
core::intrinsics::copy_nonoverlappingwith thecore::ptr::copy_nonoverlapping.This fixed this warning.