Add read_from_break method to STM32 UartRx #4702
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the purposes of receiving DMX (ANSI E1.11), or other protocols that may signal the start of a message with a break character:
This PR adds a new read method to
UartRx
, calledread_from_break
, with the following logic:Other logic remains the same, i.e. if a second break occurs before the read is complete, this is still a framing error.
I've validated this on an STM32L476RG (usart_v3) but no other chips or peripheral versions so far.
I did attempt to implement this outside of embassy code, but found the first few bytes were consistently missed unless handling this in the interrupt.
Please let me know if you think there's a better approach, or would like any changes!