stm32/adc: merge v2 and v3 ringbuffers #4832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoviat
changed the title
|
ping @Jacke-debug |
|
Good that you started working on this @xoviat! I'm mainly waiting for feedback on my own two PRs: #4243 and #4786. The second one includes all changes from the first also but it may be preferable to merge in parts. The second one also has an example that highlights how to use the new contributions from both of them so that example may be a good staring point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So #4583 has teardown but not setup. It seems that teardown should not be pub, since once it's called, it's not possible to use the dma again. Then there is dma stop, which clears the dma buffer. My proposed interface is:
aden; does not affect dmaaden; does not affect dma but waits until adc is read.