Clean chip and core target dir before generating#98
Merged
diondokter merged 2 commits intoembassy-rs:mainfrom May 4, 2026
Merged
Clean chip and core target dir before generating#98diondokter merged 2 commits intoembassy-rs:mainfrom
diondokter merged 2 commits intoembassy-rs:mainfrom
Conversation
Draft
Contributor
|
Believe it or not, but it was worse in the past :P But this is good to have, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current generator impl doesn't clean the target directory when generating.
This means that if you rename a peripheral, the old files will still remain (unless you manually delete them).
Doing this also uncovered that you couldn't actually start from scratch with a few of the PACs because it tried to call rustfmt on mod.rs when the files it referred to didn't exist yet.
This addresses the "how do I remove old files" aspects of #96