Increase mtu for ble_bas_peripheral for esp examples #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lure23
reviewed
Jan 12, 2025
| const L2CAP_MTU: usize = 251; | ||
| /// Size of L2CAP packets | ||
| #[cfg(not(feature = "esp"))] | ||
| pub const L2CAP_MTU: usize = 128; |
There was a problem hiding this comment.
Please note that this changes the behaviour for non-esp compilations. Here, the value used is 251, unlike in the place the code was copied from.
There was a problem hiding this comment.
Ooops. Reverted to 251 for non esp.
|
/test |
eloycoto
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229