Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to glimmer components #685

Merged
merged 35 commits into from
Sep 4, 2023

Conversation

mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Aug 4, 2023

Changes

  • all classic components are now glimmer components
  • liquid-if, liquid-bind, liquid-outlet dosn't have anymore position paramenters (not supported by glimmer components)
  • mixins were removed
  • LiquidVersions has new parameter (@containerElement). This is necessary, because there was used an internal, depreacted property from classic components (nearestWithProperty) to detect the nearest liquid-child element. The paramter must be passed when the consumer app is using LiquidContainer or when the app has used @containerless as paramenter for any liquid component
  • outletName is not anymore supported
  • some bug fixes, which were introduced by addonV2 switch
  • fix for Discrepancy between changelog and compatibility table #671

This changes are braking and makes part of addonV2 switch (#681)

@mkszepp mkszepp requested a review from ef4 August 4, 2023 12:08
@mkszepp
Copy link
Collaborator Author

mkszepp commented Aug 18, 2023

@ef4 have you any time for review? If no, so i will merge it and make a release. So the consumer app can report additional problems which were not detected with tests / docs page

Copy link
Collaborator

@ef4 ef4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, overall looks good.

I didn't have a change to try running this in an app, but as long as you're available to deal with any followup issues, this is ready to go.

@mkszepp mkszepp merged commit f5b6b88 into ember-animation:master Sep 4, 2023
16 checks passed
@mkszepp mkszepp deleted the update-to-glimmer branch March 30, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants